This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [v3 patch] Add std::tr1::shared_ptr

On Mon, Feb 21, 2005 at 12:02:33PM -0600, Benjamin Kosnik wrote:

> > It'd be possible to get rid of that. I think easiest would be to run it
> > and expect it to fail at runtime (since it would throw with exceptions
> > enabled or abort() without).  Does that sound OK?
> Sounds great.

I committed the code. The file that checked __EXCEPTIONS was split into
three XFAIL files that work with -fno-exceptions.

> > > All you need to do is make sure -fno-exceptions compiles cleanly. (It
> > > looks like you've tested this. Am I correct?)
> > 
> > I did test it, but a while ago. I'll check again.

This patch makes another file an XFAIL and changes the other XFAILs to
ensures that we notice if a different exception to bad_weak_ptr is thrown.

OK to commit?

2005-02-22  Jonathan Wakely

	* testsuite/tr1/2_general_utilities/memory/enable_shared_from_this/ Add comments.
	* testsuite/tr1/2_general_utilities/memory/enable_shared_from_this/ Check for wrong type of exception.
	* testsuite/tr1/2_general_utilities/memory/enable_shared_from_this/ Likewise.
	* testsuite/tr1/2_general_utilities/memory/shared_ptr/cons/ Change test to XFAIL to behave consistently
	when -fno-exceptions is used.


Message terminated with signal 11, SIGFAULT

Attachment: shared_ptr_tests.patch
Description: Text document

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]