This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] for PR 18687

From: James E Wilson <wilson at specifixinc dot com>
To: Mark Mitchell <mark at codesourcery dot com>
Cc: Zdenek Dvorak <dvorakz at suse dot cz>,Richard Henderson <rth at redhat dot com>, gcc-patches at gcc dot gnu dot org
Date: Mon, 21 Feb 2005 15:37:25 -0800
Subject: Re: [patch] for PR 18687
References: <20050208164124.GA27095@atrey.karlin.mff.cuni.cz> <200502111505.j1BF5BD17036@makai.watson.ibm.com> <4219345E.2050107@codesourcery.com>

Mark Mitchell wrote:

Zdenek, from your original posting it sounded like the two improvements that you made should not affect the generated code. Did you expect your change to have other side-effects?

This same patch also fixed PR 18977 as a side effect. I didn't bother fully analyzing the problem, but my suspicion is that it was fixed by the addition of per_type to may_eliminate_iv. The new code is clearly doing a type conversion that wasn't performed by the original code, and hence this is clearly not just a compile-time only change. In this case, however, the patch did something good.

The code is also a little sloppy here. There is a redundant assignment to wider_type that could be deleted. -- Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com

References:
- [patch] for PR 18687
  - From: Zdenek Dvorak
- Re: [patch] for PR 18687
  - From: David Edelsohn
- Re: [patch] for PR 18687
  - From: Mark Mitchell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]