This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[gfortran, committed] Obvious fix, remove failing test


Steve,

you committed two new tests without posting to the mailing list.  These tests
are failing.  It is a policy to not have failing tests in the testsuite, even
if the point out an error.  Please open a PR instead the next time.

The attached patch, which I committed under the obviously correct rule fixes
the issue with int_1.f90.  I also removed achar_1.f90, as I wasn't able to
quickly identify the cause of the failure.

Thanks,
- Tobi

Index: fortran/ChangeLog
===================================================================
RCS file: /cvs/gcc/gcc/gcc/fortran/ChangeLog,v
retrieving revision 1.323
diff -u -p -r1.323 ChangeLog
--- fortran/ChangeLog   13 Feb 2005 15:32:45 -0000      1.323
+++ fortran/ChangeLog   21 Feb 2005 14:03:19 -0000
@@ -1,3 +1,8 @@
+2005-02-21  Tobias Schl"uter  <tobias.schlueter@physik.uni-muenchen.de>
+
+       * simplify.c (get_kind): Add detail to error message.
+       (gfc_simplify_int): Check argument's kind against INTEGER kinds.
+
 2005-02-13  Tobias Schl"uter  <tobias.schlueter@physik.uni-muenchen.de>

        * trans-stmt.c (generate_loop_for_temp_to_lhs,
Index: fortran/simplify.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/fortran/simplify.c,v
retrieving revision 1.17
diff -u -p -r1.17 simplify.c
--- fortran/simplify.c  18 Jan 2005 12:11:54 -0000      1.17
+++ fortran/simplify.c  21 Feb 2005 14:03:20 -0000
@@ -127,7 +127,7 @@ get_kind (bt type, gfc_expr * k, const c
       || gfc_validate_kind (type, kind, true) < 0)
     {

-      gfc_error ("Invalid KIND parameter of %s at %L", name, &k->where);
+      gfc_error ("Invalid KIND parameter (%d) of %s at %L", kind, name,
&k->where);
       return -1;
     }

@@ -1473,7 +1473,7 @@ gfc_simplify_int (gfc_expr * e, gfc_expr
   gfc_expr *rpart, *rtrunc, *result;
   int kind;

-  kind = get_kind (BT_REAL, k, "INT", gfc_default_real_kind);
+  kind = get_kind (BT_INTEGER, k, "INT", gfc_default_integer_kind);
   if (kind == -1)
     return &gfc_bad_expr;

Index: testsuite/ChangeLog
===================================================================
RCS file: /cvs/gcc/gcc/gcc/testsuite/ChangeLog,v
retrieving revision 1.5061
diff -u -p -r1.5061 ChangeLog
--- testsuite/ChangeLog 21 Feb 2005 13:02:52 -0000      1.5061
+++ testsuite/ChangeLog 21 Feb 2005 14:03:28 -0000
@@ -1,3 +1,7 @@
+2005-02-21  Tobias Schl"uter  <tobias.schlueter@physik.uni-muenchen.de>
+
+       * gfortran.dg/achar_1.f90: Remove failing test.
+
 2005-02-20  Tobias Schl"uter  <tobias.schlueter@physik.uni-muenchen.de>

        * gfortran.dg/do_iterator: Split loop, markup all lines for


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]