This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] PR19951 fix (ICE in vectorizer)





Richard Henderson <rth@redhat.com> wrote on 17/02/2005 21:01:18:

> > !       edge e = loop_preheader_edge (loop);
> > !       if (!e->flags & EDGE_ABNORMAL)
>
> Parenthesis error.

oy

> But if a preheader edge is abnormal, we've got other
> bugs elsewhere.
>

I'll remove this check from here

> >     /* Make sure there exists a single-predecessor exit bb:  */
> > !   if (EDGE_COUNT (loop->single_exit->dest->preds) != 1)
> >       {
> > !       edge e = loop->single_exit;
> > !       if (!e->flags & EDGE_ABNORMAL)
>
> Again with the parenthesis.  This one I could believe.  What this would
> mean is that you've got an infinite loop with *only* an eh edge that
exits
> the loop.  Does this description match with the test case?

yes!:

  if (inetd_controlled)
    do_drwho (smr_server);
  else
    {

      for (;;)
        do_drwho (smr_server);


    }

I'll test the fixed patch an resend

thanks,

dorit

>
>
> r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]