This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Split simplify_unary_operation and simplify_binary_operation


While knowing an answer is interesting on its own, I withdraw the patch as it miscompiles the C++ front-end on i686-pc-linux-gnu.

I apologize for replying to myself, the patch is fine.


The failure mode was quite peculiar: the patch was bootstrapped and tested. Today I decided to rebootstrap and recheck it, so I updated my working copy, fired "make bubblestrap && make -k check", and went to lunch.

Problem is, I had only updated the gcc directory, so the libstdc++-v3 testsuite was using a PCH file made with the *previously built* compiler. I don't know exactly was changed, but it was enough to make gt_pch_restore overwrite random bits in memory, and not enough to make the compiler crash nor to have it recognize the invalid file.

I am thinking that some timestamp of the compiler ought to go in the PCH file... I will see what I can cook, and in the meanwhile I repropose my patch since it has bootstrapped and regtested fine on two platforms.

Paolo


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]