This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [tcb] Incremental SSA updates


Hello,

> > > Just changing the phi_result to null lets me remove the unmark/mark
> > > calls, without the rest of your patch apply.
> > > I highly suspect the bug is elsewhere in your code if this test is
> > > failing.
> > > The perfect_nestify code doesn't do anything illegal on that testcase.
> > 
> > use the patch below to reproduce the problem.
> > rewrite_into_loop_closed_ssa currently masks the problem,
> > at the expense of causing a misscompilation.
> 
> Uh, of course that won't work.
> It doesn't have valid ssa until rewrite_into_loop_closed_ssa is
> finished.
> We ask it to do renaming.

nope.  rewrite_into_loop_closed_ssa expects a valid ssa form on entry,
and will not work correctly otherwise.  If you need updating ssa form,
you must do it by other means (rewrite_ssa_into_ssa in mainline).

Zdenek


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]