This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PR bootstrap/19818: fix libcpp warnings (take 2)


On 10/02/2005, at 2:25 AM, Paolo Bonzini wrote:

See the previous discussion on why you can't make GCed stuff 'const'.

You did not answer to Zack's comments then:

> > these data structures are not truly
> > write-once; any pointers contained in them will be changed by saving
> > a PCH.
>
> Sure; however, that happens behind the back of the code that uses this
> data structure. The 'const' is correctly placed to catch bugs in that
> code, which is what I care about.

Zack's comment is correct, from a certain point of view. However, that point of view is not shared by the compiler building GCC; that compiler thinks that code in the GC is also part of "the code that uses this data structure".

The rest of the patch looks fine to me.

Attachment: smime.p7s
Description: S/MIME cryptographic signature

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]