This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PR bootstrap/19818: fix libcpp warnings


Paolo Bonzini <paolo.bonzini@lu.unisi.ch> writes:

> libcpp still has warnings when compiled with GCC 4.0.
>
> This is evident when you use --enable-bootstrap, which is how I tested
> this patch.  As a nice side effect, this patch makes the marker
> functions emitted by gengtype accept a const void *.  This makes sense
> because it is not the pointer that is changed, and allows one to use
> const more liberally in structs.
>
> The change to libcpp/macro.cc looked like a pasto to me.
>
> Bootstrapped/regtested powerpc-apple-darwin, ok for mainline?

I don't see why you added getopt and basename to the AC_CHECK_DECLS
list.  It's lbasename and getopt_long that are used, and the macros
that you defined are not referenced anywhere.

Please run the gengtype changes by Geoff Keating.

Otherwise ok.

zw


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]