This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] cse.c: gcc_assertify an "if" statement whose condition is always false.

From: Jakub Jelinek <jakub at redhat dot com>
To: Jeffrey A Law <law at redhat dot com>
Cc: Mark Mitchell <mark at codesourcery dot com>, Kazu Hirata <kazu at cs dot umass dot edu>, gcc-patches at gcc dot gnu dot org
Date: Thu, 27 Jan 2005 15:12:02 -0500
Subject: Re: [patch] cse.c: gcc_assertify an "if" statement whose condition is always false.
References: <20050126.152130.98713307.kazu@cs.umass.edu> <20050126205345.GI10340@devserv.devel.redhat.com> <41F84953.1060604@codesourcery.com> <20050126.210907.71115209.kazu@cs.umass.edu> <41F943A2.9060509@codesourcery.com> <1106855427.27492.53.camel@localhost.localdomain>
Reply-to: Jakub Jelinek <jakub at redhat dot com>

On Thu, Jan 27, 2005 at 12:50:27PM -0700, Jeffrey A Law wrote:
> Well, I definitely prefer having the assert vs just removing the code
> as Jakub suggested.

Well, I'd remove the code and added comment that documented that x
must be non-NULL.

	Jakub

Follow-Ups:
- Re: [patch] cse.c: gcc_assertify an "if" statement whose condition is always false.
  - From: Richard Henderson

References:
- [patch] cse.c: gcc_assertify an "if" statement whose condition isalways false.
  - From: Kazu Hirata
- Re: [patch] cse.c: gcc_assertify an "if" statement whose condition is always false.
  - From: Jakub Jelinek
- Re: [patch] cse.c: gcc_assertify an "if" statement whose conditionis always false.
  - From: Mark Mitchell
- Re: [patch] cse.c: gcc_assertify an "if" statement whose conditionis always false.
  - From: Kazu Hirata
- Re: [patch] cse.c: gcc_assertify an "if" statement whose conditionis always false.
  - From: Mark Mitchell
- Re: [patch] cse.c: gcc_assertify an "if" statement whose conditionis always false.
  - From: Jeffrey A Law

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]