This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] Fix reload inheritance bug
- From: bernds_cb1 at t-online dot de (Bernd Schmidt)
- To: Eric Botcazou <ebotcazou at libertysurf dot fr>
- Cc: gcc-patches at gcc dot gnu dot org, Mark Mitchell <mark at codesourcery dot com>
- Date: Tue, 25 Jan 2005 17:26:28 +0100
- Subject: Re: [PATCH] Fix reload inheritance bug
- References: <firstname.lastname@example.org>
Bootstrapped/regtested today on amd64-mandrake-linux-gnu. OK for mainline?
2005-01-24 Eric Botcazou <email@example.com>
Patch from Richard Sandiford <firstname.lastname@example.org>
* reload1.c (choose_reload_regs): Prevent the find_equiv_reg() code
from inheriting a subreg equivalence with a non-spill register.
From the discussion it seems like there's quite a lot of things wrong
in this area, and the patch doesn't try to address them. Ideally we
should find a fix that allows us to actually use these subregs for
inheritance, rather than disabling them altogether. This patch feels
more like a workaround than a solution, but for now I can't think of
another easy way to fix it.
However, the change does look safe to me, and it should fix the main
problem. Mark - any preferences whether you'd like this in gcc-4.0?