Re: [objc] Patch for PR18408 (Was: Re: Objective-C bugs and GCC releases)

[Ziemowit Laski <zlaski at apple dot com>]

On 24 Jan 2005, at 18.56, Alexander Malmberg wrote:

> Ziemowit Laski wrote:
> > On 24 Jan 2005, at 17.41, Alexander Malmberg wrote:
> > > objc/ChangeLog:
> > > 2005-01-25  Alexander Malmberg  <alexander@malmberg.org>
> > >
> > >     * objc-act.c (objc_types_compatible_p): New function.
> > Also #include "langhooks-def.h"; please also update Make-lang.in.
>
> objc/Make-lang.in already has:
>
> objc/objc-act.o : objc/objc-act.c \
> [snip]
>    $(LANGHOOKS_DEF_H) $(HASHTAB_H) c-pragma.h gt-objc-objc-act.h
>    ^^^^^^^^^^^^^^^^^^
>
> so if I understand this correctly, I don't need to add anything here.

Ok. :-)

> [snip]
> > > +    {
> > > +      return c_types_compatible_p (type1, type2);
> > If you could put in #ifdef OBJCPLUS for cxx_types_compatible_p() (or 
> > whatever it's called), that would be great.
>
> cxx_types_compatible_p is right. Done, although I haven't tested the 
> obj-c++ part.

That's fine; at this point, you really can't. :-)

> [snip]
> > Also, please include the comp-types-7.m test case.
>
> I'm assuming you mean Pinski's test case from the PR.

Yes.  In fact, you probably should put the magic 'PR objc/18408' string 
in the ChangeLog entries so that Bugzilla picks it up.

Thanks,

--Zem