This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [gfortran] Fix PR19194 : type mismatch between library and compiler
Paul Brook wrote:
>>2005-01-06 Tobias Schlueter <tobias.schlueter@physik.uni-muenchen.de>
>>gcc/fortran/
>> PR fortran/19194
>> * trans-io.h: Update copyright years.
>> (gfc_build_io_library_fndecls): 'rec' and 'recl_in' are not pointer
>> fields.
>>
>>libgfortran/
>> PR fortran/19194
>> * io/io.h: Update copyright years.
>> (st_parameter): Use 'GFC_INTEGER_4' instead of 'int', use CHARACTER
>> macro for definition of string valued paramters.
>
>
> Ok with one nit below.
> Note that this still isn't totally correct. These should be something similar
> to gfc_offset, with magic in trans-io.c to DTRT when this doesn't match the
> user-supplied variable. However we are at least consistently wrong with this
> patch.
>
>
>>+#define CHARACTER(name) \
>>+ char * name; \
>>+ GFC_INTEGER_4 name ## _len
>
>
> Should be gfc_charlen_type (the compiler end may also need fixing).
Done, together with the corresponding trivial change to the compiler.
- Tobi