This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Disable tree-ssa DSE for now


On Wed, 2005-01-19 at 13:06 +0100, Steven Bosscher wrote:
> On Wednesday 19 January 2005 07:44, Mark Mitchell wrote:
> > Jeffrey A Law wrote:
> > >>I agree.  If the optimizer experts agree that this pass is ineffective,
> > >>Steven's patch should be applied.
> > >
> > > It largely depends on what one considers ineffective.  I can say with
> > > absolute confidence that the current implementation is able to eliminate
> > > stores that the RTL implementation is unable to eliminate.
> >
> > That doesn't sound all that ineffective to me, then.  I'm not eager to
> > disable stuff that's doing some good.
> 
> OK, Jeff suggested disabling just one pass instead of both, which seems
> reasonable, so I tried it.  I disabled the first DSE pass with the patch
> below:
> 
> ---------------------------------------------------------------------
> 	* tree-optimize.c (init_tree_optimization_passes): Only
> 	do a single DSE pass.  Disable the first pass.
> 
> testsuite/
> 	* gcc.dg/tree-ssa/20040216-1.c: Look in the .dse dump, not .dse1.
I'm fine with this assuming that you've done all the usual testing.

jeff



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]