This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch for gcc.dg/tree-ssa/loop-1.c test case on IA64.

Steve Ellcey wrote:
A target list can now consist of an effective-target keyword.  Eventually
it would be nice to support logical operators in a target list, but we
don't now.  It's really ugly, but you could define an effective target
for everything except those two and use its keyword in the final check,
as in:

/* { dg-final {scan-assembler times "foo" 5 { target not_hppa_or_ia64 } } } */.


Setting up a special effective-target keyword sounds like a lot of work
for one test.  How about the following?

/* { dg-final {scan-assembler times "foo" 5 { xfail hppa-*-* ia64-*-* } } } */
/* { dg-final {scan-assembler-times "foo,%r" 5 { target hppa-*-* } } }      */
/* { dg-final {scan-assembler-times "= foo" 5 { target ia64-*-* } } }       */

Is the listing of two triplet patterns in the xfail considered kosher?
I found a few examples of it in other tests.

That would work, but it would be confusing, as it would not seem that there's some test in this file which is failing on PA and IA64, when that's not really true. You could mitigate that with a comment, but I'd prefer that we not abuse XFAIL in this way.

I know this stuff is a hassle.

Mark Mitchell
CodeSourcery, LLC
(916) 791-8304

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]