This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] tree-ssa-dom.c: Speed up tree_ssa_dominator_optimize.


Kazu Hirata wrote:
Hi,

Attached is a patch to speed up tree_ssa_dominator_optimize by
removing a call to mark_dfs_back_edges.

Jeff removed all uses of EDGE_DFS_BACK in tree-ssa-dom.c, so we don't
need to call mark_dfs_back_edges.

Tested on i686-pc-linux-gnu. OK to apply?

This series of patches looks plausible, though I'll leave them to others to approve. However, you could make this kind of patch more attractive if you would indicate what kind of improvement you've seen when compiling a benchmark of your choice. If the improvement is truly tiny, then it may not be worth (a) taking the risk of changing the code, even in an obvious way, and (b) taking up the time of approvers to review the patch. On the other hand, if the improvements are significant, you'll attract more interest from reviewers.


--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]