This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch]: Don't append redundant $(WERROR) to $(cp-warn)
- From: Geoffrey Keating <geoffk at geoffk dot org>
- To: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: 12 Jan 2005 16:49:57 -0800
- Subject: Re: [patch]: Don't append redundant $(WERROR) to $(cp-warn)
- References: <200501110426.j0B4QxJG013423@caip.rutgers.edu>
"Kaveh R. Ghazi" <ghazi@caip.rutgers.edu> writes:
> The $(STRICT_WARN) variable already contains -Werror, so appending
> $(WERROR) to $(cp-warn) is redundant. The current output log shows
> that -Werror appears twice when compiling cp/ directory files in
> stage2 and stage3. Fixed with the patch below, this makes the cp
> directory consistent with e.g. the java, objc and treelang
> directories.
>
> Tested via bootstrap on i686-unknown-linux-gnu and visually inspecting
> the output log to ensure that only one -Werror appears per invocation
> of the compiler.
>
> Ok for mainline?
OK.
> Thanks,
> --Kaveh
>
>
> 2005-01-10 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
>
> * Make-lang.in (cp-warn): Don't append $(WERROR).
>
> diff -rup orig/egcc-CVS20050109/gcc/cp/Make-lang.in egcc-CVS20050109/gcc/cp/Make-lang.in
> --- orig/egcc-CVS20050109/gcc/cp/Make-lang.in 2004-11-29 13:53:56.000000000 -0500
> +++ egcc-CVS20050109/gcc/cp/Make-lang.in 2005-01-10 22:08:00.000000000 -0500
> @@ -88,7 +88,7 @@ CXX_AND_OBJCXX_OBJS = cp/call.o cp/decl.
> CXX_OBJS = cp/cp-lang.o stub-objc.o $(CXX_AND_OBJCXX_OBJS)
>
> # Use strict warnings for this front end.
> -cp-warn = $(STRICT_WARN) $(WERROR)
> +cp-warn = $(STRICT_WARN)
>
> cc1plus$(exeext): $(CXX_OBJS) $(BACKEND) $(LIBDEPS)
> $(CC) $(ALL_CFLAGS) $(LDFLAGS) -o $@ \