This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH,gfortran] Remove homegrown isdigit and isalpha in module.c

From: DJ Delorie <dj at redhat dot com>
To: tobias dot schlueter at physik dot uni-muenchen dot de
Cc: sgk at troutmask dot apl dot washington dot edu, fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
Date: Mon, 10 Jan 2005 15:11:09 -0500
Subject: Re: [PATCH,gfortran] Remove homegrown isdigit and isalpha in module.c
References: <20050109211543.GA5925@troutmask.apl.washington.edu> <41E1A276.4060706@physik.uni-muenchen.de>

> Modules are of course compiler-generated, but it would be safer and not much
> more complicated to say
>    else if ('a' <= c <= 'z' || 'A' <= c <= 'Z')
> instead.

It would be wrong to do this.  Of the two most popular charset
encodings (ascii and ebcdic), only one (ascii) has the alphabet in
sequence like that.

Follow-Ups:
- Re: [PATCH,gfortran] Remove homegrown isdigit and isalpha in module.c
  - From: Tobias Schlüter

References:
- [PATCH,gfortran] Remove homegrown isdigit and isalpha in module.c
  - From: Steve Kargl
- Re: [PATCH,gfortran] Remove homegrown isdigit and isalpha in module.c
  - From: Tobias Schlüter

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]