This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE:[PATCH]: New Port ( MAXQ)

Thanks for devoting your time to see our work.

> License notices should refer to "GCC" rather than "GNU CC".
 We have replaced all instances of "GNU CC" with "GCC".

> Please do not include comments on target macro definitions that just 
> duplicate the internals manual. Only include comments on target macro
definitions where they have something to say specific to that particular
 We have removed all the comments that just duplicated the internals manual.
And all the comments are specific to our port only.

> Please follow the check-list for new targets at
 We have followed the check-list for the new targets provided at the above
link. The documentation changes in .texi  files is provided in a separate
patch which is attached.

> The options defined in TARGET_SWITCHES need documenting. 
 We have added the comments for these TARGET_SWITCHES in the maxq.h file and
the documentation is provided in the separate patch of .texi files as
mentioned above.

> There appears to be incomplete support for some target attributes: 
> maxq_assembler_function_p uses lookup_attribute but there is no
TARGET_ATTRIBUTE_TABLE definition.  If target attributes are to be
supported, then they need documenting.
> There may be other defects.
 We have removed the use of function maxq_assembler_function_p.

> All functions in maxq.c need a comment above them explaining what the 
> function does, its arguments (if any) and its return value (if any); 
> see the GNU Coding Standards for details.  Functions with no arguments are
defined using (void) rather than just ().
 We have seen the GNU Coding Standards and made the changes in the maxq.c
file according to the Standards.

The new patches are attached.

Konark Goel

Attachment: HCLT_MAXQ_GCC_10012005.tar.gz
Description: Binary data

Attachment: TEXI_PATCH.TXT
Description: Text document

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]