This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

change visibility tests to use hidden/default


Darwin only has 'hidden' and 'default', so it's better to use those
(otherwise you would have to prevent this test running on Darwin).

Tested by running dejagnu on these tests on powerpc-darwin.

===File ~/patches/gcc-testsuite-fvisdarwin.patch============
2005-01-01  Geoffrey Keating  <geoffk@geoffk.org>

	* g++.dg/ext/visibility/fvisibility-override1.C: Test using
	'hidden' and 'default' for better portability.
	* g++.dg/ext/visibility/fvisibility-override2.C: Likewise.

Index: g++.dg/ext/visibility/fvisibility-override1.C
===================================================================
RCS file: /cvs/gcc/gcc/gcc/testsuite/g++.dg/ext/visibility/fvisibility-override1.C,v
retrieving revision 1.1
diff -u -p -r1.1 fvisibility-override1.C
--- g++.dg/ext/visibility/fvisibility-override1.C	25 Jul 2004 22:52:21 -0000	1.1
+++ g++.dg/ext/visibility/fvisibility-override1.C	2 Jan 2005 02:25:57 -0000
@@ -2,9 +2,9 @@
 /* { dg-do compile } */
 /* { dg-require-visibility "" } */
 /* { dg-options "-fvisibility=hidden" } */
-/* { dg-final { scan-assembler "\\.internal.*Foo.methodEv" } } */
+/* { dg-final { scan-not-hidden "methodEv" } } */
 
-class __attribute__ ((visibility ("internal"))) Foo
+class __attribute__ ((visibility ("default"))) Foo
 {
   void method();
 };
Index: g++.dg/ext/visibility/fvisibility-override2.C
===================================================================
RCS file: /cvs/gcc/gcc/gcc/testsuite/g++.dg/ext/visibility/fvisibility-override2.C,v
retrieving revision 1.1
diff -u -p -r1.1 fvisibility-override2.C
--- g++.dg/ext/visibility/fvisibility-override2.C	25 Jul 2004 22:52:21 -0000	1.1
+++ g++.dg/ext/visibility/fvisibility-override2.C	2 Jan 2005 02:25:57 -0000
@@ -2,11 +2,11 @@
 /* { dg-do compile } */
 /* { dg-require-visibility "" } */
 /* { dg-options "-fvisibility=hidden" } */
-/* { dg-final { scan-assembler "\\.internal.*Foo.methodEv" } } */
+/* { dg-final { scan-not-hidden "Foo.methodEv" } } */
 
 class Foo
 {
-  __attribute__ ((visibility ("internal"))) void method();
+  __attribute__ ((visibility ("default"))) void method();
 };
 
 void Foo::method() { }
============================================================


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]