This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Don't forget to pop timevar


Volker Reichelt <reichelt@igpm.rwth-aachen.de> writes:

| Right at the beginning of the function pushtag in cp/name-lookup.c
| we have "timevar_push (TV_NAME_LOOKUP);". However, we leave the
| function in one path without popping the variable again. Only
| mainline is affected.
| 
| The following patch fixes that.
| 
| Ok to commit once bootstrapping and regtesting succeeded?

I think the patch qualifies as obvious, and being the perpetrator of
POP_TIMEVAR_AND_RETURN I believe the patch is fine.  And it fixes a
bug (my understanding is that we're back to bug-fixing mode).

| Btw, there are two instances - one in pushdecl_class_level in
| name-lookup.c and one in define_label in decl.c - where we have
| the sequence
| 
|   timevar_push (TV_NAME_LOOKUP);
|   return some_variable;
| 
| Should I replace these with
| 
|   POP_TIMEVAR_AND_RETURN (TV_NAME_LOOKUP, some_variable);
| 
| for consistencey?

Yes.

-- Gaby


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]