This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: NetWare update

On Tue, Dec 21, 2004 at 11:20:56AM +0100, Jan Beulich wrote:
> >> >> gcc/testsuite/
> >> >> 	* gcc.dg/20040813-1.c: xfail and don't execute dg-final for
> >> >> 	*-*-netware.
> >> >
> >> >See the immediately preceeding skip-if.  Means you don't need
> >> >the dg-error line at the end.
> >>
> >> I'm not sure I understand what you're trying to say here.
> >
> >Seems clear to me.  Just add *-*-netware to make that line say:
> >/* { dg-skip-if "No stabs" { mmix-*-* *-*-aix* *-*-netware } { "*" } {
> "" } } */
> This is what I considered obvious and thus tried first. It didn't work
> as appearantly intended, as described earlier (i.e. it didn't prevent
> dg-final from getting executed).

Use of dg-xfail-if says that the compilation is expected to fail.  It
doesn't affect other directives like dg-final.

Using TCL expressions within test files is frowned upon, besides which
they aren't always evaluated by the the time they are needed.

> I'm attaching gcc.log as requested; I can't attach stdout resulting
> from "-v -v -v" due to size limitations this list places on mails.
> To me it boils down to (as said before) compile_flags not being set at
> the time dg-skip-if (and from there check_conditional_xfail, where
> compile_flags are used) gets evaluated, as can be seen in the attached
> file, where "Compiler flags are: " is followed by nothing, which of
> course doesn't match against "* * *".

I've apparently done all of my testing passing -m32 or -m64 to all tests
so I hadn't seen the failure of dg-skip-if when there are no options.
I'll look into that to see if there's a fix that doesn't involve procs
within DejaGnu.  In the meantime, for that particular test try moving
the dg-option directive before dg-skip-if.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]