This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] GCC 3.4.3: libobjc build failure


At Mon, 20 Dec 2004 16:38:36 -0500,
Andrew Pinski wrote:
> 
> 
> On Dec 20, 2004, at 4:35 PM, Denis Zaitsev wrote:
> 
> > This patch is for exactly the same issue as described in
> >
> > http://gcc.gnu.org/ml/gcc/2002-12/msg00033.html
> >
> > The fix is exactly the same, just another file is the target.  Without
> > it libobjc fails to build when --with-objc-gc is given to configure.
> 
> This patch is incorrect as noted before.  I am going to reject it
> as it was rejected before.  Again libobjc has no reason to include
> these headers.

The patch is the Wrong Thing in a formal sense.  However, it may be
the correct thing to do in the short term.  libobjc files have been
including coretypes.h and tm.h for a very long time; adding a few more
is not the end of the world, especially not on an old release branch!

zw


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]