This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Reorder some tree codes




On Mon, 20 Dec 2004, Giovanni Bajo wrote:

Nathan Sidwell <nathan@codesourcery.com> wrote:

This patch reorders the _TYPE codes and a few others to allow
range comparison to determine certain kinds of types.  This showed
a 0.25% speed improvement on darwin, and a 2% text size reduction in
cc1plus.


I do not like this because we lose clarity in the definition of the macros, and
thus we make debugging much harder.

It's not just that, it's that the in_range changes mean that the compiler will break if you move tree codes around in tree.def.


That seems just wrong to me.
I have no issues with the part of the patch moving them around, i only have issues with depending on their ordering at the *source* level.


This definitely seems like something the compiler should be doing, and not manually doing in our source base.

--Dan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]