This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Really fix PR18596


On Sun, 19 Dec 2004, James A. Morrison wrote:

>        * c-parse.in (initdcl): Don't call finish decl if start_decl fails.

There are two calls to finish_decl (not "finish decl", please fix all the 
typos in your ChangeLog entries) from initdcl and two from notype_initdcl.  
Why are you only changing one of the four?  Have you tested corresponding 
circumstances that would trigger the other three?  (Please add such tests 
to the testsuite.)

-- 
Joseph S. Myers               http://www.srcf.ucam.org/~jsm28/gcc/
    jsm@polyomino.org.uk (personal mail)
    joseph@codesourcery.com (CodeSourcery mail)
    jsm28@gcc.gnu.org (Bugzilla assignments and CCs)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]