This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR18191


On Sat, Dec 18, 2004 at 01:15:44AM +0100, Steven Bosscher wrote:
> +       if (TREE_CODE (purpose) == RANGE_EXPR)
> +         {
> + 	  tree lower, upper;
...

This isn't pulled out to its own routine, as I asked.

> + 		    var = lower;
> + 		    do
> + 		      {
> + 			object[var] = value;
> + 			if (var >= upper)
> + 			  break;
> + 			var = var + 1;
> + 		      }
> + 		    while (true);

Use "== upper", not ">= upper".  Look at the loop routines and
you'll see it's easier for it to reason that way.


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]