This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Fix PR/18997 weak symbol bug on cygwin


On Thu, Dec 16, 2004 at 09:24:55PM +1300, Danny Smith wrote:
>Christopher Faylor wrote:
>> On Thu, Dec 16, 2004 at 03:35:36PM +1300, Danny Smith wrote:
>>>
>>> The followin patch fixes the regression. Bootstrapped and tested on
>>> i686-pc-cygwin (c,c++).
>>>
>>> gcc/ChangeLog
>>>
>>> * config/i386/cygwin.h (GTHREAD_USE_WEAK): Define to 0.
>>>
>>> libstdc++-v3/ChangeLog
>>>
>>> * config/os/newlib/os_defines.h (_GLIBCXX_GTHREAD_USE_WEAK):
>>> Define to 0 for __CYGWIN__.
>>
>> Ok.  For now.
>
>Does change to libstdc++ require approval from libstdc++ maintainer, or does it
>fall under target maintainer domain?   Configure option -with-newlib will make
>newlib the os_include_dir  for other targets.

Since it's protected with an 'ifdef __CYGWIN__', I think it's safe for me
to ok.

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]