Re: Excise CHAR_TYPE from Java

[Mark Mitchell <mark at codesourcery dot com>]

Gabriel Dos Reis wrote:
> Nathan Sidwell <nathan@codesourcery.com> writes:
>
> | I noticed that tree.def said this
> | 	/* CHAR in Pascal; not used in C.
> | 	   No special fields needed.  */
> | about CHAR_TYPE.  Well, it is used in Java too, but only just.  Rather
> | than fix the comment to reflect reality, I decided to fix reality (much more
> | satisfying :)
> | 
> | This patch removes the Java FE's use of CHAR_TYPE, by adding explicit
> | checks for char_type_node as appropriate -- that is what the C++ FE does
> | when it needs to distinguish identically laid out wchar_t from short or int
> | (or whatever it's identical to).
> | 
> | Obviously, if this goes in, the next step will be to nuke the uses of
> | CHAR_TYPE from the middle end.
> | 
> | booted & tested on i686-pc-linux-gnu, ok?
>
> Is this a regression?
>
> I mean this is the second similar patch and I'm confused about the
> these kinds of changes when the tree is said to be in regression mode.

We should queue this kind of thing for 4.1, unless Nathan's hoped-for 
performance improvement pans out.

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304