Re: [patch] tree-ssa-dom.c: Fix memory leak.

[Kazu Hirata <kazu at cs dot umass dot edu>]

Hi Jeff,

> > With this patch, we no longer record expressions like LE_EXPR or
> > GE_EXPR for boolean equality, but that should be OK as I don't think
> > we use LE_EXPR or GE_EXPR on booleans.
> I don't really follow what you're trying to say here.  Can you elaborate
> more?  I don't think it matters, but I would like to understand what
> you're trying to say.

Without this patch, if we enter the first "if", we would necessarily
enter the third "if".  Note that the third "if" contains calls to
record_conditions, which records expressions like LE_EXPR and GE_EXPR
if the original expression is EQ_EXPR.  For boolean expressions,
however, I don't think we would get anything out of recording LE_EXPR
or GE_EXPR because "bool_1 <= true" is always true.  "bool_1 >= true"
is just the same as "bool_1 == true".  Here I am assuming that these
canonicalization of these boolean expressions happen somewhere.

Sorry for the lack of words in the first post.

> > 	* tree-ssa-dom.c (record_edge_info): Fix memory leak.
> OK.

Thanks.

Kazu Hirata