This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix Ada bootstrap on darwin


> It's desirable to use linkonce .bss on systems that support both
> linkonce and common, because that way the linkonce section can be put
> into a COMDAT group (if and when we ever get around to implementing
> that *sigh*).

Ok, but I don't think that it was necessary to eliminate old fashion
common on systems that provide one-only support for initialized data,
especially since COMDAT groups aren't implemented.  Linkonce .bss
support is a relatively new feature and I don't think it was a factor
when the MAKE_DECL_ONE_ONLY macro was introduced.

I guess the problem could be worked around if the "DECL_ONE_ONLY (decl)
= 1;" statement were moved before the "MAKE_DECL_ONE_ONLY (decl);"
statement in make_decl_one_only.  This would allow a backend to choose
whatever form of one-only support it thought best.

Dave
-- 
J. David Anglin                                  dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada              (613) 990-0752 (FAX: 952-6602)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]