This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RS6000] Fix PR16952, -mrelocatable broken


>>>>> "Aldy" == Aldy Hernandez <aldyh@redhat.com> writes:

>>>>> "Alan" == Alan Modra <amodra@bigpond.net.au> writes:
 >> On Sun, Dec 05, 2004 at 11:52:40AM +0100, Eric Botcazou wrote:
 >>> #ifndef RELOCATABLE_NEEDS_FIXUP

 > Hi Alan.  Hi folks.

 > This breaks the embedded targets (sysv4 ones anyhow).  The function
 > rs6000_assemble_integer uses the macro as an lvalue, but sysv4.h
 > defines it emptily.

 > The patch below fixes the problem.  Is this OK?

On second thought, Alan has just convinced me this is an obvious fix.
Committing to mainline and 3.4 branch.

 > Aldy

 > 	* config/rs6000/sysv4.h: Define RELOCATABLE_NEEDS_FIXUP to 1.

 > Index: config/rs6000/sysv4.h
 > ===================================================================
 > RCS file: /cvs/gcc/gcc/gcc/config/rs6000/sysv4.h,v
 > retrieving revision 1.155
 > diff -c -p -r1.155 sysv4.h
 > *** config/rs6000/sysv4.h	29 Oct 2004 17:09:05 -0000	1.155
 > --- config/rs6000/sysv4.h	6 Dec 2004 16:00:28 -0000
 > *************** ncrtn.o%s"
 > *** 1367,1370 ****
 >   #define DOUBLE_INT_ASM_OP "\t.quad\t"
  
 >   /* Generate entries in .fixup for relocatable addresses.  */
 > ! #define RELOCATABLE_NEEDS_FIXUP
 > --- 1367,1370 ----
 >   #define DOUBLE_INT_ASM_OP "\t.quad\t"
  
 >   /* Generate entries in .fixup for relocatable addresses.  */
 > ! #define RELOCATABLE_NEEDS_FIXUP 1


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]