This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] enable push/pop for xstormy16
On Thu, 2004-12-02 at 19:55 -0500, Daniel Jacobowitz wrote:
> On Thu, Dec 02, 2004 at 04:07:39PM -0800, Eric Christopher wrote:
> > Turns out the name was wrong for these to get recognized as named
> > patterns and therefore used.
> >
> > As a side effect it also fixed:
> >
> > struct-by-value-2
> > struct-by-value-3
> > struct-by-value-4
> > struct-return-2
> > struct-return-3
> >
> > OK?
>
> That's a very strange side effect for this patch. Did you look at why
> this happened?
A bit. It looked like we weren't keeping the offset in the instruction
when we were storing arguments to the stack in emit_single_push_insn.
Then I noticed that we weren't emitting the push instruction when we
should as well anyhow. After emitting the push we were generating
correct code there, and it became less important (though I've still got
a note in my sources to investigate it at some point) to determine what
else we were doing wrong.
-eric