This is the mail archive of the
mailing list for the GCC project.
Re: [patch] O(1) PHI argument look-up - Part 20/n
- From: Jeffrey A Law <law at redhat dot com>
- To: Kazu Hirata <kazu at cs dot umass dot edu>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 02 Dec 2004 09:30:42 -0700
- Subject: Re: [patch] O(1) PHI argument look-up - Part 20/n
- Organization: Red Hat, Inc
- References: <email@example.com>
- Reply-to: law at redhat dot com
On Thu, 2004-12-02 at 10:20 -0500, Kazu Hirata wrote:
> Attached is part 20 of my O(1) PHI argument look-up patch.
> phi_arg_from_edge never returns -1. The return value of -1 used to
> mean that a PHI argument is missing for a given edge. These days, a
> "missing PHI argument" is represented by putting NULL_TREE in the
> corresponding PHI argument slot, so we have to use
> gcc_assert (PHI_ARG_DEF (phi, e) != NULL_TREE);
> The patch updates two instances of gcc_assert. Also, the patch moves
> two uses of phi_arg_from_edge out of the loop as their results are
> loop invariant.
> Tested on i686-pc-linux-gnu. OK to apply?
> Kazu Hirata
> 2004-12-02 Kazu Hirata <firstname.lastname@example.org>
> * tree-cfg.c (phi_alternatives_equal): Check that PHI_ARG_DEF
> is not null.