This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: Many Failures In libjava Testsuite!


Good point.  I had forgotten than GC_LINUX_THREADS also gets
defined this way.

There is actually an alternative here.  If you unconditionally define
GC_THREADS before including gc.h, gc_config_macros.h (included from
gc.h) should define the right platform-dependent GC_..._THREADS
macro for you, precisely to address this problem.  But this has
probably not been exhaustively tested on all platforms.  (If it
breaks somewhere, the fix will be pretty obvious.)

Eventually we should switch to just defining GC_THREADS.
Whether this should happen for 4.0 is another issue.

Hans

> -----Original Message-----
> From: java-patches-owner@gcc.gnu.org
> [mailto:java-patches-owner@gcc.gnu.org]On Behalf Of Tom Tromey
> Sent: Wednesday, December 01, 2004 8:33 AM
> To: Bryce McKinlay
> Cc: Kelley Cook; gcc-patches@gcc.gnu.org; java-patches@gcc.gnu.org;
> Nathanael Nerode
> Subject: Re: Many Failures In libjava Testsuite!
> 
> 
> >>>>> "Bryce" == Bryce McKinlay <mckinlay@redhat.com> writes:
> 
> Bryce> I suspect there will still be problems with only 
> THREAD_LOCAL_ALLOC
> Bryce> defined - see PR 18699. These problems didn't show up in the
> Bryce> regression suite for me, only with the TT.java file 
> given in that PR.
> 
> On my machine, gc_config.h defines GC_LINUX_THREADS.  This is
> examined by gc_config_macros.h to define GC_PTHREADS.  This in turn
> is examined by gc.h to include gc_pthread_redirects.h, which is
> needed for the GC to intercept various pthread calls.
> 
> Kelley, this general idea looks ok to me.  I would suggest changing
> the logic to remove the problem defines and leave the rest.  But, it
> would be prudent to wait for the test case before committing anything.
> 
> Tom
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]