This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Many Failures In libjava Testsuite!
- From: Tom Tromey <tromey at redhat dot com>
- To: Bryce McKinlay <mckinlay at redhat dot com>
- Cc: Kelley Cook <kcook at gcc dot gnu dot org>, gcc-patches at gcc dot gnu dot org, java-patches at gcc dot gnu dot org, Nathanael Nerode <neroden at gcc dot gnu dot org>
- Date: 01 Dec 2004 09:32:47 -0700
- Subject: Re: Many Failures In libjava Testsuite!
- References: <coeq1l$s24$1@sea.gmane.org> <41AB0AE3.2020406@gmail.com><41ABC1F2.4050707@redhat.com> <41ACBD00.8080200@gcc.gnu.org><41ACD014.2040504@redhat.com>
- Reply-to: tromey at redhat dot com
>>>>> "Bryce" == Bryce McKinlay <mckinlay@redhat.com> writes:
Bryce> I suspect there will still be problems with only THREAD_LOCAL_ALLOC
Bryce> defined - see PR 18699. These problems didn't show up in the
Bryce> regression suite for me, only with the TT.java file given in that PR.
On my machine, gc_config.h defines GC_LINUX_THREADS. This is
examined by gc_config_macros.h to define GC_PTHREADS. This in turn
is examined by gc.h to include gc_pthread_redirects.h, which is
needed for the GC to intercept various pthread calls.
Kelley, this general idea looks ok to me. I would suggest changing
the logic to remove the problem defines and leave the rest. But, it
would be prudent to wait for the test case before committing anything.
Tom