Re: [patch] O(1) PHI argument look-up - Part 19/n

[Mark Mitchell <mark at codesourcery dot com>]

Diego Novillo wrote:
> On Mon, 2004-11-29 at 07:48 -0500, Diego Novillo wrote:
>
> > On Mon, 2004-11-29 at 00:38 -0500, Kazu Hirata wrote:
> >
> >
> > > 	* tree-ssa.c (ssa_redirect_edge): Use PHI_CHAIN in the "for"
> > > 	loop.
> >
> > OK.
>
> Hmm, I had forgotten about the freeze.  Maybe this could wait for 4.1.
> It is  an obvious fix, but we are in a freeze after all.  Mark, what do
> you think?  (Patch at http://gcc.gnu.org/ml/gcc-
> patches/2004-11/msg02524.html)

It doesn't look like a "fix" at all to me; it's a cleanup.  As such, it 
should wait until mainline reopens.

I think that patches to speed up PHI argument lookup are fine; those fix 
compile-time problems with optimization, where we know there are 
regressions.  But this change on itself can probably wait.

All that said, I've no interest in being incredibly picky.  If this has 
already gone in, that's fine.

Thanks,

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304