This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, gfortran] g77's FNUM, STAT, FSTAT, and FLUSH intrinsics


On Wed, Nov 24, 2004 at 11:05:51PM +0200, Janne Blomqvist wrote:
> On Wed, Nov 24, 2004 at 08:53:56AM -0800, Steve Kargl wrote:
> 
> Hi, just yet another small trivial nitpick..

Thanks for the comments.  

> > ChangeLog for libgfortran:
> > 
> >         * io/unix.c: Move comment to top, move struct unix_stream to ...
> >         * io/unix.h: ... here
> 
> Hmm, I think the idea is that unix_stream should be contained within
> unix.c.

intrinsics/flush.c implements g77's FLUSH intrinsic subroutine.
It is defined to work on UNIX(tm) systems, so I need access to
unix_stream.  See g77.info for details about FLUSH.

> > Index: io/unix.c
> > ===================================================================
> > RCS file: /cvsroot/gcc/gcc/libgfortran/io/unix.c,v
> > retrieving revision 1.13
> > diff -u -b -u -r1.13 unix.c
> > --- io/unix.c	30 Oct 2004 16:23:23 -0000	1.13
> > +++ io/unix.c	24 Nov 2004 16:45:55 -0000
> 
> >  /* fd_flush()-- Write bytes that need to be written */
> >  
> > -static try
> > +try
> >  fd_flush (unix_stream * s)
> >  {
> 
> ... so it's not necessary to make fd_flush non-static, just use flush
> instead.

FLUSH from g77 flushes a UNIX(tm) stream.  Ergo, the use of
fd_flush in intrinsics/flush.c.  If you or Paul or someone
else wants to generalize FLUSH to flush any stream, then
have at it.  

-- 
Steve


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]