This is the mail archive of the
mailing list for the GCC project.
Re: [C++ PATCH] [PR18354] Unary plus as template argument
- From: Nathan Sidwell <nathan at codesourcery dot com>
- To: GCC Patches <gcc-patches at gcc dot gnu dot org>, Giovanni Bajo <giovannibajo at libero dot it>
- Date: Mon, 22 Nov 2004 10:56:21 +0000
- Subject: Re: [C++ PATCH] [PR18354] Unary plus as template argument
- Organization: Codesourcery LLC
The most recent patch is ok, but whilst you're there how about breaking
! if (!(arg = build_expr_type_conversion (flags, arg, true)))
! errstring = (code == NEGATE_EXPR
! ? "wrong type argument to unary minus"
! : "wrong type argument to unary plus");
out of the conditional?
btw, you can also keep Kazu happy by fixing the typo here
! /* Make sure the result is not a lvalue: an unary plus or minus
! expression is always a rvalue. */
it's 'a unary plus'. Here the 'u' is pronounced as 'you', so 'a' is correct,
if it were 'uh' (as in 'umpire'), 'an' would be appropriate.
ok with those changes.
Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery LLC
firstname.lastname@example.org :: http://www.planetfall.pwp.blueyonder.co.uk