This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: hot/cold partitioning bug fix
- From: Mike Stump <mrs at apple dot com>
- To: Geoff Keating <geoffk at geoffk dot org>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sun, 21 Nov 2004 13:18:49 -0800
- Subject: Re: hot/cold partitioning bug fix
On Saturday, November 20, 2004, at 12:22 PM, Geoff Keating wrote:
(I don't know if I said this originally or forgot, but what I'm
concerned about is that text_section() is not correct for a coalesced
function.)
If you analyze the patch, we do text_section strictly less often, and
the only case in which we do even that, is when reorder_and_partition
is on, so what exactly your concern is, escapes me.
It really really needs a testcase. Clearly there must be no existing
tests for it, or they'd be failing. It's important to get the bugs
fixed, but it's just as important to have at least some tests or the
bugs will just reappear.
Ok, I understand. We can leave it broken if you prefer...