This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Testsuite patch for Solaris 10


Janis Johnson wrote:

On Mon, Nov 15, 2004 at 05:20:26PM -0800, Mark Mitchell wrote:


Joseph S. Myers wrote:



On Mon, 15 Nov 2004, Janis Johnson wrote:



{ dg-skip-if message { targets } { include } { exclude } }

The following would skip a test on an i?86 target when -m64 is one of
the command-line options.  The dg-do target list could specify all
targets on which to run the test.

{ dg-skip-if "" { i?86 } { "*" } { "-m64" } }

This has the advantage of looking like dg-xfail-if.


It also has the advantage of being such that the same dg-skip-if specification would naturally be used both for the x86-only tests which have plain dg-forbid-option and for the tests with special options on x86 that condition dg-forbid-option on being a x86 target. It looks good to me as a dg-forbid-option replacement.




I agree.



Mark and Joseph, how's this? Tested on powerpc64-unknown-linux-gnu
with -m32 and -m64 just to make sure nothing weird happened, and with
contrived tests using dg-skip-if. Eventually I hope to document all
of the dg- directives used in GCC tests.


I like it. And I really appreciate that you made the changes to the existing tests yourself!

--
Mark Mitchell
CodeSourcery, LLC
(916) 791-8304
mark@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]