This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] libffi support for CRIS
- From: Tom Tromey <tromey at redhat dot com>
- To: Hans-Peter Nilsson <hp at bitrange dot com>
- Cc: Simon Posnjak <simon dot posnjak at siol dot net>, GCC Patches <gcc-patches at gcc dot gnu dot org>, java-patches at gcc dot gnu dot org, green at redhat dot com
- Date: 16 Nov 2004 09:51:41 -0700
- Subject: Re: [PATCH] libffi support for CRIS
- References: <1098703798.10993.29.camel@matilda.kranj.cetrtapot.si><Pine.BSF.4.58.0410251900210.26076@dair.pair.com><1098789150.5095.248.camel@matilda.kranj.cetrtapot.si><Pine.BSF.4.58.0410272224530.86355@dair.pair.com><1098956572.7120.106.camel@matilda.kranj.cetrtapot.si><Pine.BSF.4.58.0410290755130.74648@dair.pair.com>
- Reply-to: tromey at redhat dot com
>>>>> "H-P" == Hans-Peter Nilsson <hp@bitrange.com> writes:
H-P> I'll fix up all issues below and would like to start negotiation
H-P> with libffi approvers. I'd like to hear from them about this
H-P> patch (for reference,
H-P> <URL:http://gcc.gnu.org/ml/gcc-patches/2004-10/msg02477.html>).
Sorry for the long delay on this.
H-P> I ask for approval on the target-independent changes there,
H-P> minus the globalization of initialize_aggregate plus comments
H-P> at the #ifdef additions to the effect of
H-P> /* The CRIS ABI specifies structure elements to the effect of
H-P> byte alignment only, so it completely overrides this
H-P> functions, which assumes "natural" alignment and padding. */
Makefile.am: Ok
configure.ac: Ok
prep_cif.c: with the omission you mention, ok
types.c: Ok
For the initialize_aggregate change, if that function becomes
non-static then it will have to have an "ffi_" prefix added to its
name.
Let me know if there's something I missed.
Perhaps someday it would be nice to have things like the #ifndef
around ffi_prep_cif be controlled by a feature macro set in the port's
header file, rather than ad hoc target defines all over.
Tom