This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[patch] testsuite: revert patch that added dg-target-list


This patch reverts a testsuite patch from last week that added
dg-target-list, which provided the ability to use TCL expressions to
create a "target" or "xfail" list within any dg- command in a test.
I hadn't realized that it's a goal to swap test tools without modifying
tests, so using TCL within a test is not a good thing after all.  I
hadn't yet checked in any test changes to use this new construct.
Committed to mainline.

2004-11-15  Janis Johnson  <janis187@us.ibm.com>

	* lib/gcc-dg.exp (dg-target-list): Remove.

Index: lib/gcc-dg.exp
===================================================================
RCS file: /opt/gcc-cvs/gcc/gcc/testsuite/lib/gcc-dg.exp,v
retrieving revision 1.42
diff -u -p -r1.42 gcc-dg.exp
--- lib/gcc-dg.exp	12 Nov 2004 22:22:16 -0000	1.42
+++ lib/gcc-dg.exp	15 Nov 2004 18:51:08 -0000
@@ -506,26 +506,6 @@ proc dg-xfail-if { args } {
     }
 }
 
-# Given an optional keyword "target" or "xfail" and the result of a
-# condition which has been evaluated by the framework, return a list
-# containing the keyword and "*-*-*" if the condition is true or
-# "empty-empty-empty" if the condition is false.
-
-proc dg-target-list { what cond } {
-    switch $what {
-	"target" { set result [list $what] }
-	"xfail"  { set result [list $what] }
-	""       { set result [list] }
-	default  { error "`$what' not allowed here" }
-    }
-    if { $cond } {
-	lappend result "*-*-*"
-    } else {
-	lappend result "empty-empty-empty"
-    }
-    return $result
-}
-
 # We need to make sure that additional_* are cleared out after every
 # test.  It is not enough to clear them out *before* the next test run
 # because gcc-target-compile gets run directly from some .exp files


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]