This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] passes.c: Remove a cut-n-paste error.
- From: Paolo Bonzini <bonzini at gnu dot org>
- To: Kazu Hirata <kazu at cs dot umass dot edu>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 04 Nov 2004 14:40:05 +0100
- Subject: Re: [patch] passes.c: Remove a cut-n-paste error.
- References: <20041104.082807.102766668.kazu@cs.umass.edu>
If you look at the patch, it's obvious that there is the same code
repeated twice. I don't know the gory details about those functions
called within the "if" statement, but none of them seems to require
two iterations as far as I can tell from their function names.
You're right, when the second "if" is executed basic_block_info is set
and we skip everything.
Actually *both* copies should be spurious now, since now
rest_of_compilation is never called except from the pass manager.
Paolo