Re: [gfortran] Patch for PR 17590: Tagging intrinsics with standard version

[Janne Blomqvist <jblomqvi at cc dot hut dot fi>]

On Sun, Oct 31, 2004 at 03:56:52PM +0200, Janne Blomqvist wrote:
> Anyway, I reopened the bug since I noticed that you had made some
> style changes which broke it. Copy-pasting my explanation from
> bugzilla:
> 
> """
> 
> I'm reopening this PR since a bug crept in, apparently Paul changed the code to
> be C89 conformant while it depended on C99 VLA:s to function properly. If you
> look at intrinsic.c:check_intrinsic_standard you see that originally it contained:
> 
>   int name_len;
>   name_len = strlen(name);
>   char msgstr[name_len + 53];
> 
> while the committed version has:
> 
>   int name_len;
>   char msgstr[name_len + 53];
> 
> i.e. msgstr is allocated before the correct length is known. I'll try to fix it
> asap with some __builtin_alloca magic..
> 
> """

Ok, patch is attached. Note that Graham Stott already has submitted a
patch (which uses gfc_getmem) to bugzilla, but I'll submit mine too
since I already had it done when I noticed his.

ChangeLog:

	PR fortran/17590

	* intrinsic.c (check_intrinsic_standard): Use __builtin_alloca to
	allocate message string on the stack.


-- 
Janne Blomqvist

Attachment: pr17590_3.patch
Description: Text document