This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix PR c++/17729 double deprecated warning

From: Mark Mitchell <mark at codesourcery dot com>
To: Andrew Pinski <pinskia at physics dot uc dot edu>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Sat, 30 Oct 2004 11:04:55 -0700
Subject: Re: [PATCH] Fix PR c++/17729 double deprecated warning
Organization: CodeSourcery, LLC
References: <E73FA6FC-2901-11D9-9310-000A95D692F4@physics.uc.edu>

Andrew Pinski wrote:

We were warning twice for deprecated on a function if we call the function.
The way to fix this is not to warn when we are building the call as we have
already warned about the decl after figuring out what the decl is.

OK for 3.4 and the mainline.

Can you prove that with your patch we will not fail to issue a deprecated warning in some other situation? There are a lot of ways to get to build_call.

To fix this kind of defect, you need to write documentation explaining whose responsibility it is to issue the warning. It should be clear that all deprecated functions will be caught by one of the chokepoints listed in your documentation. Then, make sure that the chokepoints all contain code to issue the warning, writing test cases, ideally. Then remove the code to issue warnings that is not in the checkpoints.

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com

References:
- [PATCH] Fix PR c++/17729 double deprecated warning
  - From: Andrew Pinski

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]