This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Fix ObjC instance variable lookup in class methods


On 29 Oct 2004, at 11.14, Zack Weinberg wrote:


Ziemowit Laski wrote: ...
While I was at it, I cleaned up c-typeck.c so that ObjC-related
processing no longer takes place there.  This should improve
compile-time performance for plain C slightly.  The decision whether
an ivar or another C/C++ symbol should be used has now been moved to
objc_lookup_ivar() itself (with the C/C++ symbol passed in as an
additional parameter).

I like this. Clarify the comment a little, e.g.


  /* In Objective-C, an instance variable (ivar) may be preferred to
     whatever lookup_name found.  */

Will do, thanks.



and I'll approve the C part of this change -- but wait 24 hours in case one of the official C maintainers (e.g. Joseph) disagrees.

OK.


--Zem


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]