This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] tree-ssa-dce.c: Don't let an explicit GOTO_EXPR slipthrough.
- From: Jeffrey A Law <law at redhat dot com>
- To: Kazu Hirata <kazu at cs dot umass dot edu>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 27 Oct 2004 10:22:56 -0600
- Subject: Re: [patch] tree-ssa-dce.c: Don't let an explicit GOTO_EXPR slipthrough.
- Organization: Red Hat, Inc
- References: <20041027.004254.85685161.kazu@cs.umass.edu>
- Reply-to: law at redhat dot com
On Wed, 2004-10-27 at 00:42 -0400, Kazu Hirata wrote:
> Hi,
>
> Attached is a patch to teach DCE not to let an explicit GOTO_EXPR slip
> through.
>
> All of simple GOTO_EXPRs are represented implicitly. If we have an
> "if" statement checking for a simple GOTO_EXPR, we might as well turn
> that into gcc_assert.
>
> verify_flow_info has an identical check, so you could argue that
> gcc_assert would be duplicate. In any case, we shouldn't have an "if"
> there because that deceive us into thinking we handle two different
> kinds of GOTO_EXPR, ones that satisfy simple_goto_p and ones that
> don't.
>
> Tested on i686-pc-linux-gnu. OK to apply?
>
> Kazu Hirata
>
> 2004-10-27 Kazu Hirata <kazu@cs.umass.edu>
>
> * tree-ssa-dce.c (mark_stmt_if_obviously_necessary)
> <GOTO_EXPR>: Don't let an explicit GOTO_EXPR slip through.
This is fine.
jeff