This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFC: modify ppc expanders to support e500
- From: David Edelsohn <dje at watson dot ibm dot com>
- To: Aldy Hernandez <aldyh at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, geoffk at geoffk dot org
- Date: Fri, 22 Oct 2004 17:33:16 -0400
- Subject: Re: RFC: modify ppc expanders to support e500
- References: <20041022205015.GA26919@redhat.com>
The first thing that jumps out to me is a style comment.
fpr_extendsfdf2 is not referenced anywhere else that I can see in the
patch, so the name should be prepended with "*". Second, the rest of the
port generally makes the name unique at the end, e.g., "*extendsfdf2_fpr"
or "*extendsfdf2_noe500".
David