This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Vectorizer: bug fix for component ref support


> Why are we checking anything other than ARRAY_TYPE?

just a sanity check to make sure that we are getting here only array forms
that we know that we support. It used to be only arrays which base is a
VAR_DECL; then we added struct support, multidimensional support, and
pointers support, so this check was gradually relaxed. It may be that in
its current form it actually allows all possible forms of arrays we can get
in GIMPLE (is that the case?) and is therefore redundant or should go under
ENABLE_CHECKING. OK if we do that?

dorit



                                                                                                                           
                      Richard Henderson                                                                                    
                      <rth@redhat.com>         To:       Ira Rosen/Haifa/IBM@IBMIL                                         
                                               cc:       gcc-patches@gcc.gnu.org, Dorit Naishlos/Haifa/IBM@IBMIL           
                      12/10/2004 18:49         Subject:  Re: [patch] Vectorizer: bug fix for component ref support         
                                                                                                                           




On Tue, Oct 12, 2004 at 03:21:30PM +0200, Ira Rosen wrote:
>     is_array_ref = TREE_CODE (data_ref_base_type) == ARRAY_TYPE
>                         && (TREE_CODE (data_ref_base) == VAR_DECL
>                             || TREE_CODE (data_ref_base) == COMPONENT_REF
> !                           || TREE_CODE (data_ref_base) == ARRAY_REF
> !                    || TREE_CODE (data_ref_base) == INDIRECT_REF);

Why are we checking anything other than ARRAY_TYPE?


r~




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]