Re: [PATCH] Fix PACKAGE_* redefined warnings in libjava.

[Bryce McKinlay <mckinlay at redhat dot com>]

Kelley Cook wrote:

> > Kelly,
> >
> > Just FYI: "gc_config.h" was introduced partly to avoid the PACKAGE_* 
> > redefinition warnings. gc_config.h.in was deliberately not 
> > autoheader-generated, so that it only exported a few symbols that
> > needed 
> > to be "public" ie visibile to clients outside the GC - ie libjava. Is
> > there any reason why gc_config.h.in must be an autoheader generated
> > file?
> >    
>
> Of course it isn't a "must" to autogenerate gc_config.h.in, hence
> option 1) which revert the previous patch.
>
> On the otherhand, installing this patch lets autoreconf work again and
> reduces the chance that a particular AC_DEFINE is added to configure.ac
> or *.m4, but not to the corresponding gc_config.h.in.
>  

The thing is, gc_config.h needs to be included by code outside of 
boehm-gc, so ideally it should only define a few things that actually 
need to be externally visible, in order to avoid potential conflicts 
with other defines in other packages. If we wanted to properly autoconf 
boehm-gc, I'd imagine there'd be a separate, regular config.h for 
internal definitions.

Just guessing, but would putting in a dummy config.h make autoheader happy?

Regards

Bryce