This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: libstdc++/17789: Cannot 'make check' inside libstdc++-v3
- From: "H. J. Lu" <hjl at lucon dot org>
- To: gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
- Cc: Paolo Carlini <pcarlini at suse dot de>, Andreas Schwab <schwab at suse dot de>
- Date: Mon, 4 Oct 2004 11:28:47 -0700
- Subject: Re: PATCH: libstdc++/17789: Cannot 'make check' inside libstdc++-v3
- References: <20041001155756.GB1094@lucon.org> <415D80E4.1050005@suse.de> <20041001214603.GA7148@lucon.org> <415DD2FD.8040809@suse.de> <20041001222528.GA7863@lucon.org> <415DDAF4.7070006@suse.de> <20041001232117.GC8657@lucon.org> <415DF2CB.7010601@suse.de> <20041002232856.GA30503@lucon.org> <20041002234042.GA10202@disaster.jaj.com>
On Sat, Oct 02, 2004 at 07:40:42PM -0400, Phil Edwards wrote:
>
> Again, for the Nth time, H.J., you need to cc libstdc++@ on patches which
> affect it.
>
I will try to remember that.
>
> On Sat, Oct 02, 2004 at 04:28:56PM -0700, H. J. Lu wrote:
> > include $(top_srcdir)/fragment.am
> >
> > +# Set up library path if needed.
> > +@set_gcc_lib_path@
> > +
> > if GLIBCXX_HOSTED
> > hosted_source = libmath src po testsuite
> > endif
> [...]
> >
> > include $(top_srcdir)/fragment.am
> >
> > +# Set up library path if needed.
> > +@set_gcc_lib_path@
> > +
>
> These need some comments. Pointing to the TC_AM_blahblahblah macro is
> probably good enough. Something, at the very least, indicating what's
> responsible for setting the value.
Here is the new patch.
>
> Has this been regtested on platforms other than ia64?
>
I tested it on ia32, ia64 and x86-64:
http://gcc.gnu.org/ml/gcc-testresults/2004-10/msg00190.html
http://gcc.gnu.org/ml/gcc-testresults/2004-10/msg00189.html
http://gcc.gnu.org/ml/gcc-testresults/2004-10/msg00188.html
H.J.
------
2004-10-04 H.J. Lu <hongjiu.lu@intel.com>
PR libstdc++/17789
* Makefile.am (@set_gcc_lib_path@): Added.
* testsuite/Makefile.am (@set_gcc_lib_path@): Added.
* Makefile.in: Regenerated.
* testsuite/Makefile.in: Regenerated.
* acinclude.m4: Include ../config/gcc-lib-path.m4.
* aclocal.m4: Regenerated.
* configure.ac: Use TL_AC_GNU_MAKE_GCC_LIB_PATH.
* configure: Regenerated.
--- libstdc++-v3/Makefile.am.ld-path 2004-08-02 16:25:37.000000000 -0700
+++ libstdc++-v3/Makefile.am 2004-10-04 11:06:40.000000000 -0700
@@ -24,6 +24,10 @@
include $(top_srcdir)/fragment.am
+# Set up library path if needed. See TL_AC_GNU_MAKE_GCC_LIB_PATH in
+# config/gcc-lib-path.m4 at top level.
+@set_gcc_lib_path@
+
if GLIBCXX_HOSTED
hosted_source = libmath src po testsuite
endif
--- libstdc++-v3/acinclude.m4.ld-path 2004-09-28 12:02:09.000000000 -0700
+++ libstdc++-v3/acinclude.m4 2004-10-01 17:32:47.000000000 -0700
@@ -1748,4 +1748,6 @@ AC_DEFUN([AC_LIBTOOL_DLOPEN])
AC_DEFUN([AC_PROG_LD])
])
+sinclude(../config/gcc-lib-path.m4)
+
dnl vim:et:ts=2:sw=2
--- libstdc++-v3/configure.ac.ld-path 2004-09-28 12:02:11.000000000 -0700
+++ libstdc++-v3/configure.ac 2004-10-01 17:32:47.000000000 -0700
@@ -308,6 +308,8 @@ else
fi
AC_SUBST(LIBSUPCXX_PICFLAGS)
+TL_AC_GNU_MAKE_GCC_LIB_PATH
+
dnl In autoconf 2.5x, AC_OUTPUT is replaced by four AC_CONFIG_* macros,
dnl which can all be called multiple times as needed, plus one (different)
dnl AC_OUTPUT macro. This one lists the files to be created:
--- libstdc++-v3/testsuite/Makefile.am.ld-path 2004-05-13 07:56:35.000000000 -0700
+++ libstdc++-v3/testsuite/Makefile.am 2004-10-04 11:06:52.000000000 -0700
@@ -25,6 +25,10 @@ AUTOMAKE_OPTIONS = dejagnu
include $(top_srcdir)/fragment.am
+# Set up library path if needed. See TL_AC_GNU_MAKE_GCC_LIB_PATH in
+# config/gcc-lib-path.m4 at top level.
+@set_gcc_lib_path@
+
AM_MAKEFLAGS = -j1
AM_RUNTESTFLAGS =